Updated naming to match with Resharper#177
Merged
Merged
Conversation
Owner
|
You really want to update our guideline to match a bug in R#/Rider? |
Contributor
Author
|
No, to match the default setting from Resharper. The bug is only preventing to override that default in obvious ways. It's not helpful when someone is writing event handler code, then gets a squiggle from CSharpGuidenlinesAnalyzer each time because the naming does not match our pattern. That person then tries to adapt the Resharper setting and gets stuck. Given this unfortunate combination of things, makes me wonder why we are deviating at all? |
Owner
|
Because it's not English? 🤔 |
Contributor
Author
|
That's probably because JetBrains is Russian at heart :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have discussed this before. However it turns out there's been a bug in Resharper for many years, which prevents users from changing Resharper's default behavior. And a fix is still not implemented nor planned (feel free to upvote the bug report).
So I updated texts to match with the default Resharper settings for now.